Do not run tasks when their prerequisites fail #142
Merged
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptarjan
force-pushed
the
ptarjan-MultiTask
branch
from
575ee8b to
cdfbc74
Compare
|
Can you add a test for this as well? I think something like this will adequately simulate cross-thread exceptions (but I didn't try it): def test_cross_thread_prerequisite_failures
failed = false
task :fail_once do
fail_now = !failed
failed = true
raise 'failing once' if fail_now
end
task a: :fail_once
task b: :fail_once
assert_raises RuntimeError do
Rake::Task[:a].invoke
end
assert_raises RuntimeError do
Rake::Task[:b].invoke
end
end |
If tasks A and B both depend on C, they race to grab the invocation lock on C. If A wins, it sets @already_invoked and executes C while holding the lock. When C completes, A releases the lock, B acquires it and immediately returns since C is @already_invoked. Unfortunately, this does not distinguish failed execution of C. Instead, if executing C raises an exception for A, we want to raise the same exception in B so it is aborted.
ptarjan
force-pushed
the
ptarjan-MultiTask
branch
from
cdfbc74 to
3a1b5bc
Compare
|
@drbrain added. Thanks for the starting point. I had to make one of them a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tasks A and B both depend on C, they race to grab the invocation
lock on C. If A wins, it sets @already_invoked and executes C while
holding the lock. When C completes, A releases the lock, B acquires it
and immediately returns since C is @already_invoked. Unfortunately,
this does not distinguish failed execution of C. Instead, if executing
C raises an exception for A, we want to raise the same exception in B
so it is aborted.